Conversation
The season param is supported by the schedule endpoint in mlb stats api, we must start supporting this since passing season will allow to retrieve a whole season schedule.
schedule method must support season param.
Add endpoints for team and game uniforms
latest_season returns first season which hasn't ended
Add include_series_status flag to schedule()
Allow extra keyword arguments to requests.get() in get()
Allow 'season' argument to player_stats
Collaborator
Author
|
I have preemptively updated the relevant wiki pages as well |
add debug logging for request_kwargs in get()
toddrob99
approved these changes
Apr 4, 2025
Owner
toddrob99
left a comment
toddrob99
left a comment
There was a problem hiding this comment.
Great work, much appreciated! All I did was format with black and add a debug log entry for request_kwargs in get().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
game_uniformsandteam_uniforms(Add endpoints for team and game uniforms #154)schedule()supports theseasonargument to get an entire season's games at once (schedule method must support season param. #149)player_stats()andplayer_stats_data()support theseasonargument to get previous seasons of stats (Allow 'season' argument to player_stats #161)get()now accepts arequests_kwargsdict which are passed as extra arguments torequests.get()(Allow extra keyword arguments to requests.get() in get() #159)Bug fixes:
latest_season()function to return the upcoming season, not just whatever the most recent in MLB's data is (latest_season returns first season which hasn't ended #157)schedule()supports passinginclude_series_status=Falseto not request the series status from the endpoint, which can fail when requesting schedules covering large periods of time (Add include_series_status flag to schedule() #158)